Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12279] Instructor home page: Improve display of card header on mobile #12512

Closed

Conversation

AnkitaPatil2002
Copy link

Fixes #12279

Outline of Solution

I have added media query for maxwidth 767px displayed it to column

issuefix

I have added a space between card-header btn-toolbar as it is displayed before card-header-btn-toolbar

converted all the dropmenu-items anchor-tags to button for so that they can be picked up by screen readers.

@github-actions
Copy link

Hi @AnkitaPatil2002, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@AnkitaPatil2002 AnkitaPatil2002 changed the title Instructor home page: Improve display of card header on mobile #12279 [#12279] Instructor home page: Improve display of card header on mobile Jul 13, 2023
@weiquu
Copy link
Contributor

weiquu commented Jul 13, 2023

Hi @AnkitaPatil2002, do fix the failing checks before we proceed to review your PR.

converted all the dropmenu-items anchor-tags to button for so that they can be picked up by screen readers.

Do note that the <a> tags were already being picked up by screen readers, and that it makes sense for them to be read as a link since they are indeed taking the user from one page to another...

@jasonqiu212
Copy link
Contributor

Hi @AnkitaPatil2002, Thanks for making the changes! Before we can review your changes, could you fix the remaining lint issues? Thanks.

@AnkitaPatil2002
Copy link
Author

yes @jasonqiu212 I am working on it.

@jasonqiu212
Copy link
Contributor

Hi @AnkitaPatil2002, Could you look into the failing component tests? I believe some of the snapshot tests are failing.

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructor home page: Improve display of card header on mobile
4 participants