-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12279] Instructor home page: Improve display of card header on mobile #12512
[#12279] Instructor home page: Improve display of card header on mobile #12512
Conversation
Hi @AnkitaPatil2002, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
Hi @AnkitaPatil2002, do fix the failing checks before we proceed to review your PR.
Do note that the |
Hi @AnkitaPatil2002, Thanks for making the changes! Before we can review your changes, could you fix the remaining lint issues? Thanks. |
|
Hi @AnkitaPatil2002, Could you look into the failing component tests? I believe some of the snapshot tests are failing. |
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
Fixes #12279
Outline of Solution
I have added media query for maxwidth 767px displayed it to column
I have added a space between card-header btn-toolbar as it is displayed before card-header-btn-toolbar
converted all the dropmenu-items anchor-tags to button for so that they can be picked up by screen readers.